Jan Schulz

Use "class::logger"
Use "de.katzien.App.Infomail"
Use "de.katzien.App.InfomailDB"
Use "de.katzien.ls.Email"

Use "class::logger"
Use "de.katzien.App.InfomailDB"
Use "de.katzien.App.Infomail"
Use "de.katzien.ls.Email"

public function getSomething() as Something
  if oSomething is nothing then
    set oSomething = new Something()
  end if
  set getsomething = oSomething
end function

How do this with dynamic arrays? I was very surprised when this threw an error:

dim arrSomethings() as Something
if isArray(arrSomethings) then print ubound(arrSomething) ' unitialized array error when calling the ubound function 

You have to call a redim arrSomething(0 to 0) bevor you can do anything with that array. I tested it with every isXYZ function I could find in the designer help, but i couldn't find a way to detect that...Somehow I agree with Tommy Valand: LS Arrays are strange. Give me a Java collections like API and I'm happy

BTW: datatype (arrSomething) gives "8738", even after the redim, but the designer help says that "8704" is a Dynamic array. Bug?

• show the error messages to the user and get some information what the user did
• Sending the logentry via mail to the central OpenLog DB in case the user is offline

handleerror:
 If handleError() Then Resume Next

Public Function handleError() As Boolean
 '** logs whatever error happens to be on the stack (if any)
 On Error Goto processError
 
 Dim session As New NotesSession
 
 handleError = False
 
 ' First try to handle the error
 ' Loop over some handler List
 ' If any can and has handled this error, just return true
 
 Forall handler In errorHandlers 
 If handler.isResponsibleFor(Err) Then
 handleError = handler.handleError()
 End If
 If handleError = True Then
 Exit Function
 End If
 End Forall
 
 'if not:
 ' Create a log item and a document
 ' Ask the user for input with a dialog
 
 Call setupLogItem("","",Nothing,Getthreadinfo(10)) 'refactored to get rid of code duplication
 Dim db As NotesDatabase 
 
 If session.IsOnServer Then
 ' I can garantee that there is a OpenLog DB on each server
 Set db = GetLogDatabase
 globalLogSuccess = globalLogItem.WriteToLog(db)
 Else
 ' local means in most cases not online -> mail it and ask for input
 Set db = New NotesDatabase("", "")
 Call db.OpenMail 
 Dim dummyDoc As NotesDocument
 Set dummyDoc = globalLogItem.CreateLogDoc(db)
 ' Just shows a dialog, which displays some fields from the LogItem
 If askForAdditionalInformation(dummydoc) Then
 globalLogItem.message = globalLogItem.message + Chr(13)+Chr(10)+ dummydoc.GetItemValue("ErrorMessage")(0)
 End If
 Call dummydoc.Remove(True)
 ' creates a doc and uses doc.send(...) to mail it to the OpenLog Mail-In DB
 globalLogSuccess = globalLogItem.sendViaMail(db)
 End If
 
 Call ClearStackTrace()
 If Not globalLogSuccess Then
 Error 1001, "Log was not saved or sent"
 End If

 Exit Function
processError:
 DebugPrint(StandardErrorMessage(Err, Erl, Error$, Getthreadinfo(1)))
 Resume Next
 
End Function

I'm not yet satisfied: there is still some possibility to refactore code (there is much code duplication in the static methods) and I think most of the setup code (setupLogItem(...) and also for the stackTrace) could go into the classes. Also the dialog could go into a ErrorHandler: just let isResponsible(...) return true if not session.isOnServer and then return false from the handleError(). But this would need some priority in the handlers (no need to ask the user if we can handle it internaly) and a way to indicate if we are in the rethrow phase or in the final handleError()... Let's see....

Another thing is adding Context to the error (also an idea I got from the above example DB...). LogErrorEx(...) already lets you pass in some information, but it would be great if this could be more than a string: something like an object store, some variable values,... No idea yet how to implment that without registering every variable/object in a store Any Ideas?

Dim value as Variant
value = "Hallo"
Call assertThat(value, is_( not_( equalTo("Hallo") ) ).and_(is_(ofType("String")))

Resulting in output like this:

(bold is from the Matcher (second argument to assertThat), rest from the Error, which the assertThat method throws)

The Implementation is quite easy: you have a IMatcher abstract Class with several concrete matcher implementation and a static method, which returns a object of that matcher. The IsMatcher (just to have proper english sentences and the static method looks like this:

Public Function is_(matcher As IMatcher) As IMatcher
	Set is_  = New IsMatcher(matcher)
End Function

Class IsMatcher As IMatcher
	Private fMatcher As IMatcher
	
	Sub new(matcher As IMatcher) 
		Set fMatcher = matcher
	End Sub
	
	Public Function matchesSafely( value As Variant) As Boolean
		matchesSafely = fMatcher.matches(value)
	End Function

	Public Function describeMeTo(description As Description)
		description.appendText("is")
		Call fMatcher.describeTo(description)
	End Function
End Class

The testThat (just returns a boolean, assertThat uses that to throw the error) is just:

Public Function testThat(value As Variant, matcher As IMatcher) As Boolean
	testThat = matcher.matches(value)
End Functio

IMatcher.matches(variant) is a wrapper to get the IMatcher.and_(IMatcher) and IMatcher.Or_(IMatcher) methods working. In the end it returns the logical result of all included Matchers.

The IMatcher.decribeMeTo(Description) is again the internal method (describeTo(...) is the wrapper to get AND and OR working) used to get the plain english description from the matcher composite (the bold Text above).

Dim oDescription As New Description
Call matcher.describeTo(oDescription)
print oDescription.toString() 

Implemented Matchers up to now: is, not, equalTo, ofType, instanceOf, like. Feel free to add some matchers or leave a comment for other ideas

Edited, as I can upload now: LS-Hamcrest.lss

Call assertThat("Hallo", is_( not_( equalTo("Hallo") ) ).and_(is_(ofType("String"))))

Assertion failure: expected: is not equal to Hallo and is of type STRING; got: (STRING) Hallo

1. Don't mix object graph construction with application logic
2. Ask for things, Don't look for things (aka Dependency Injection / Law of Demeter)
3. Don't do work in constructor
4. Favor composition over inheritance
5. Favor polymorphism over conditionals
6. Don't mix Service Objects with Value Objects
7. Mixing of Concerns
   

	Sub delegate_Queryopen(Source As Notesuidocument, Mode As Integer, Isnewdoc As Variant, Continue As Variant)
		Forall evhandler In listEventHandlers
			Call evHandler.Queryopen(Source , Mode, Isnewdoc , Continue )
			If Not Continue Then Exit Sub
		End Forall
	End Sub
	

Private Const ERR_ABSTRACT_INSTANTIATION = 1000
Private Const MSG_ABSTRACT_INSTANTIATION = | Attempt to instantiate as an object instance the abstract class |

Public Class BaseDocumentController
%REM
The Controller Part of MVC
Binds to a UIDocument, delegates all events to the EventHandlers
%END REM
	Private fUIDoc As NotesUIDocument
	Private fModel As BaseDocumentModel
	Private fIsInitialized As Boolean
	Private listEventHandlers List As AbstractDocumentEventHandler
	
	Sub new(uidoc As NotesUIDocument)
		If Not uidoc Is Nothing Then
			Call initializeWithUIDoc(uidoc)
		End If
	End Sub
	
	Public Function getUIDoc() As NotesUIDocument
		Set getUIDoc = fUIDoc
	End Function
	
	Public Function initializeWithUIDoc(uidoc As NotesUIDocument)
		If uiDoc Is Nothing Then
			Error 1111, "Need a UI Document"
		End If
		Set fUIDoc = uidoc
		Set fModel = New BaseDocumentModel( fUIDoc.Document)
		fIsInitialized = True
		
		Call bindEvents() 
		Call setupEventHandler()
		
		
	End Function
	
%REM
adds the default EventHandler (Validation) the to eventhandler List
Can be overwritten to extend the EventHandler List, needs to call
BaseDocumentController..setupEventHandler() to get the basic EventHandler 
setup or you need to add validation yourself
%END REM
	Function setupEventHandler()
		Dim evHandler As New ValidationHandler(fModel)
		Call Me.addEventHandler( "validation", evHandler)
		Dim evHandler2 As New AuditTrailHandler(fModel)
		Call Me.addEventHandler( "AuditTrail", evHandler2)		
	End Function
	
	Public Function addEventHandler(evName As String, evHandler As AbstractDocumentEventHandler)
		Set listEventHandlers(evName) = evHandler
	End Function
	
	Private Function bindEvents()
		On Event Queryopen From fUIDoc Call delegate_Queryopen
		On Event Postopen From fUIDoc Call delegate_Postopen
		On Event Querymodechange From fUIDoc Call delegate_Querymodechange	
		On Event Postmodechange From fUIDoc Call delegate_Postmodechange
		On Event Queryrecalc From fUIDoc Call delegate_Queryrecalc
		On Event Postrecalc From fUIDoc Call delegate_Postrecalc
		On Event Querysave From fUIDoc Call delegate_Querysave
		On Event Postsave From fUIDoc Call delegate_Postsave
		On Event Querysend From fUIDoc Call delegate_Querysend
		On Event Postsend From fUIDoc Call delegate_Postsend
		On Event Queryclose From fUIDoc Call delegate_Queryclose
		
	End Function
	
	Sub delegate_Queryopen(Source As Notesuidocument, Mode As Integer, Isnewdoc As Variant, Continue As Variant)
		Forall evhandler In listEventHandlers
			Call evHandler.Queryopen(Source , Mode, Isnewdoc , Continue )
			If Not Continue Then Exit Sub
		End Forall
	End Sub
	
	Sub delegate_Postopen(Source As Notesuidocument)
		Forall evhandler In listEventHandlers
			Call evHandler.PostOpen(Source)
		End Forall	
	End Sub
	
	Private Sub delegate_Querymodechange(Source As Notesuidocument, Continue As Variant)
		Forall evhandler In listEventHandlers
			Call evHandler.Querymodechange(Source, Continue)
			If Not Continue Then Exit Sub
		End Forall
	End Sub
	
	Private Sub delegate_Postmodechange(Source As Notesuidocument)
		Forall evhandler In listEventHandlers
			Call evHandler.Postmodechange(Source)
		End Forall
	End Sub
	
	Private Sub delegate_Queryrecalc(Source As Notesuidocument, Continue As Variant)
		Forall evhandler In listEventHandlers
			Call evHandler.Queryrecalc(Source, Continue)
			If Not Continue Then Exit Sub
		End Forall
	End Sub
	
	Private Sub delegate_Postrecalc(Source As Notesuidocument)
		Forall evhandler In listEventHandlers
			Call evHandler.Postrecalc(Source)
		End Forall
	End Sub
	
	Private Sub delegate_Querysave(Source As Notesuidocument, Continue As Variant)
		Forall evhandler In listEventHandlers
			Call evHandler.Querysave(Source, Continue)
			If Not Continue Then Exit Sub
		End Forall
	End Sub
	
	Private Sub delegate_Postsave(Source As Notesuidocument)
		Forall evhandler In listEventHandlers
			Call evHandler.Postsave(Source)
		End Forall
	End Sub
	
	Private Sub delegate_Querysend(Source As Notesuidocument, Continue As Variant)
		Forall evhandler In listEventHandlers
			Call evHandler.Querysend(Source, Continue)
			If Not Continue Then Exit Sub
		End Forall
	End Sub
	
	Private Sub delegate_Postsend(Source As Notesuidocument)
		Forall evhandler In listEventHandlers
			Call evHandler.Postsend(Source)
		End Forall
	End Sub
	
	Private Sub delegate_Queryclose(Source As Notesuidocument, Continue As Variant)
		Forall evhandler In listEventHandlers
			Print "Calling eventhandler for QueryClose"
			Call evHandler.Queryclose(Source, Continue)
			If Not Continue Then Exit Sub
		End Forall
		Print "End QueryClose"
	End Sub
	
End Class

Class BaseDocumentModel
%REM
The model part of MVC
Binds to the backend document and does validation (not implmented properly) and other stuff with the data
%END REM
	Private fDoc As NotesDocument
	Private fIsInitialized As Boolean
	
	Sub new(doc As NotesDocument)
		If Not doc Is Nothing Then
			Call initializeWithDocument(doc)
		End If
	End Sub
	
	Function initializeWithDocument(doc As NotesDocument